Skip to content

[TOOL-4057] Dashboard: Update Storage pinning card in team usage page #6697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2025
Merged

[TOOL-4057] Dashboard: Update Storage pinning card in team usage page #6697

merged 1 commit into from
Apr 11, 2025

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Apr 11, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on improving the Usage component by removing the deprecated toPercent function, implementing a compactNumberFormatter, and enhancing storage metrics display. It also introduces a new formatStorageBytes function for better formatting of storage values.

Detailed summary

  • Removed the toPercent function from number.ts.
  • Added compactNumberFormatter for compact number formatting in Usage.tsx.
  • Refactored storage metrics calculation to remove reliance on toPercent.
  • Updated display of rpc and storage requests to use compactNumberFormatter.
  • Introduced formatStorageBytes function for better storage value formatting.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 11, 2025 15:18 Inactive
@vercel
Copy link

vercel bot commented Apr 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2025 3:24pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 11, 2025 3:24pm
login ⬜️ Skipped (Inspect) Apr 11, 2025 3:24pm
thirdweb_playground ⬜️ Skipped (Inspect) Apr 11, 2025 3:24pm
wallet-ui ⬜️ Skipped (Inspect) Apr 11, 2025 3:24pm

@linear
Copy link

linear bot commented Apr 11, 2025

TOOL-4057 Update Storage Pinning UI in Team usage page

@vercel vercel bot temporarily deployed to Preview – docs-v2 April 11, 2025 15:18 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 11, 2025 15:18 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2025

⚠️ No Changeset found

Latest commit: 97d45d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui April 11, 2025 15:18 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 11, 2025
@MananTank Graphite App
Copy link
Member Author

MananTank commented Apr 11, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review April 11, 2025 15:18
@MananTank MananTank requested review from a team as code owners April 11, 2025 15:18
@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.67 KB (0%) 954 ms (0%) 160 ms (+449.32% 🔺) 1.2 s
thirdweb (cjs) 130.06 KB (0%) 2.7 s (0%) 201 ms (+158.5% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.62 KB (0%) 113 ms (0%) 85 ms (+3534.77% 🔺) 198 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 57 ms (+7090.18% 🔺) 67 ms
thirdweb/react (minimal + tree-shaking) 19.36 KB (0%) 388 ms (0%) 91 ms (+1230.43% 🔺) 479 ms

@jnsdls jnsdls merged commit 316cef1 into main Apr 11, 2025
31 of 32 checks passed
@jnsdls jnsdls deleted the tool-4057 branch April 11, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

Assignees

@MananTank MananTank

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls